summaryrefslogtreecommitdiffstats
path: root/ipalib
diff options
context:
space:
mode:
authorMartin Kosek <mkosek@redhat.com>2011-11-09 14:23:15 +0100
committerMartin Kosek <mkosek@redhat.com>2011-11-09 15:31:50 +0100
commit843c0787b7e123801250b9a0fb5b974cd9fd7e7b (patch)
treeda70e275d5dfa41d39f7e11f357d6e664488a8f8 /ipalib
parentb5c049ae2e62f24c6dfce618b94f567671e238ea (diff)
downloadfreeipa-843c0787b7e123801250b9a0fb5b974cd9fd7e7b.tar.gz
freeipa-843c0787b7e123801250b9a0fb5b974cd9fd7e7b.tar.xz
freeipa-843c0787b7e123801250b9a0fb5b974cd9fd7e7b.zip
Fix DNS zone --allow-dynupdate option behavior
--allow-dynupdate was implemented as a Flag parameter type, which is not convenient for LDAP attributes. When a DNS zone with permitted dynamic updates was modified and the --allow-dynupdate flag was not set, dynamic updates were turned off. This patch changes the option type to Bool parameter type which behaves according to user expectations when modifying the zone. https://fedorahosted.org/freeipa/ticket/2039
Diffstat (limited to 'ipalib')
-rw-r--r--ipalib/plugins/dns.py20
1 files changed, 10 insertions, 10 deletions
diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index 97eb6a6d4..912fd36f0 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -23,7 +23,7 @@ import time
from ipalib import api, errors, output
from ipalib import Command
-from ipalib import Flag, Int, List, Str, StrEnum
+from ipalib import Flag, Bool, Int, List, Str, StrEnum
from ipalib.plugins.baseldap import *
from ipalib import _, ngettext
from ipalib.util import validate_zonemgr
@@ -42,6 +42,10 @@ EXAMPLES:
ipa dnszone-add example.com --name-server nameserver.example.com
--admin-email admin@example.com
+ Modify the zone to allow dynamic updates for hosts own records in realm EXAMPLE.COM:
+ ipa dnszone-mod example.com --dynamic-update=TRUE \\
+ --update-policy="grant EXAMPLE.COM krb5-self * A; grant EXAMPLE.COM krb5-self * AAAA;"
+
Add new reverse zone specified by network IP address:
ipa dnszone-add --name-from-ip 80.142.15.0/24
--name-server nameserver.example.com
@@ -395,18 +399,20 @@ class dnszone(LDAPObject):
label=_('BIND update policy'),
doc=_('BIND update policy'),
),
- Flag('idnszoneactive?',
+ Bool('idnszoneactive?',
cli_name='zone_active',
label=_('Active zone'),
doc=_('Is zone active?'),
flags=['no_create', 'no_update'],
attribute=True,
),
- Flag('idnsallowdynupdate',
- cli_name='allow_dynupdate',
+ Bool('idnsallowdynupdate?',
+ cli_name='dynamic_update',
label=_('Dynamic update'),
doc=_('Allow dynamic updates.'),
attribute=True,
+ default=False,
+ autofill=True
),
)
@@ -441,9 +447,6 @@ class dnszone_add(LDAPCreate):
del entry_attrs['name_from_ip']
entry_attrs['idnszoneactive'] = 'TRUE'
- entry_attrs['idnsallowdynupdate'] = str(
- entry_attrs.get('idnsallowdynupdate', False)
- ).upper()
# Check nameserver has a forward record
nameserver = entry_attrs['idnssoamname']
@@ -495,9 +498,6 @@ class dnszone_mod(LDAPUpdate):
def pre_callback(self, ldap, dn, entry_attrs, *keys, **options):
if 'name_from_ip' in entry_attrs:
del entry_attrs['name_from_ip']
- entry_attrs['idnsallowdynupdate'] = str(
- entry_attrs.get('idnsallowdynupdate', False)
- ).upper()
return dn
api.register(dnszone_mod)