Internationalization for public errors

Currently, we throw many public exceptions without proper i18n.
Wrap natural-language error messages in _() so they can be translated.

In the service plugin, raise NotFound errors using handle_not_found helper
so the error message contains the offending service.

Use ScriptError instead of NotFoundError in bindinstance install.

https://fedorahosted.org/freeipa/ticket/1953

1 files changed, 5 insertions, 3 deletions

diff --git a/ipalib/plugins/virtual.py b/ipalib/plugins/virtual.py
index 8db1a9653..414de4c00 100644
--- a/ipalib/plugins/virtual.py
+++ b/ipalib/plugins/virtual.py
@@ -24,6 +24,7 @@ from ipalib import api
 from ipalib import Command
 from ipalib import errors
 from ipapython.dn import DN
+from ipalib.text import _
 
 class VirtualCommand(Command):
     """
@@ -48,7 +49,7 @@ class VirtualCommand(Command):
         This should be executed before any actual work is done.
         """
         if self.operation is None and operation is None:
-            raise errors.ACIError(info='operation not defined')
+            raise errors.ACIError(info=_('operation not defined'))
 
         if operation is None:
             operation = self.operation
@@ -60,8 +61,9 @@ class VirtualCommand(Command):
 
         try:
             if not ldap.can_write(operationdn, "objectclass"):
-                raise errors.ACIError(info='not allowed to perform this command')
+                raise errors.ACIError(
+                    info=_('not allowed to perform this command'))
         except errors.NotFound:
-            raise errors.ACIError(info='No such virtual command')
+            raise errors.ACIError(info=_('No such virtual command'))
 
         return True