diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2015-03-23 12:18:23 +0100 |
|---|---|---|
| committer | Petr Vobornik <pvoborni@redhat.com> | 2015-05-12 12:41:34 +0200 |
| commit | c3d99a28a0bfed2198712c98830c2011fd6be874 (patch) | |
| tree | 61196e37990ed65612a5f8e592ea7f84354a939c /ipalib/plugins/migration.py | |
| parent | a6ca9800fa8b48b9fa71dc54cc036a17d35b6197 (diff) | |
| download | freeipa-c3d99a28a0bfed2198712c98830c2011fd6be874.tar.gz freeipa-c3d99a28a0bfed2198712c98830c2011fd6be874.tar.xz freeipa-c3d99a28a0bfed2198712c98830c2011fd6be874.zip | |
migrate-ds: optimize gid checks by utilizing dictionary nature of set
Reviewed-By: Martin Basti <mbasti@redhat.com>
Diffstat (limited to 'ipalib/plugins/migration.py')
| -rw-r--r-- | ipalib/plugins/migration.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ipalib/plugins/migration.py b/ipalib/plugins/migration.py index 919af9d7c..22bf6a8f6 100644 --- a/ipalib/plugins/migration.py +++ b/ipalib/plugins/migration.py @@ -166,11 +166,11 @@ def _pre_migrate_user(ldap, pkey, dn, entry_attrs, failed, config, ctx, **kwargs 'gidnumber', entry_attrs['gidnumber'][0], 'posixgroup', [''], search_bases['group'] ) - valid_gids.append(entry_attrs['gidnumber'][0]) + valid_gids.add(entry_attrs['gidnumber'][0]) except errors.NotFound: api.log.warn('GID number %s of migrated user %s does not point to a known group.' \ % (entry_attrs['gidnumber'][0], pkey)) - invalid_gids.append(entry_attrs['gidnumber'][0]) + invalid_gids.add(entry_attrs['gidnumber'][0]) except errors.SingleMatchExpected, e: # GID number matched more groups, this should not happen api.log.warn('GID number %s of migrated user %s should match 1 group, but it matched %d groups' \ @@ -765,8 +765,8 @@ can use their Kerberos accounts.''') context['has_upg'] = ldap.has_upg() - valid_gids = [] - invalid_gids = [] + valid_gids = set() + invalid_gids = set() migrate_cnt = 0 context['migrate_cnt'] = 0 for entry_attrs in entries: |