summaryrefslogtreecommitdiffstats
path: root/ipalib/frontend.py
diff options
context:
space:
mode:
authorJan Cholasta <jcholast@redhat.com>2013-01-28 14:55:20 +0100
committerMartin Kosek <mkosek@redhat.com>2013-01-29 15:39:49 +0100
commit77bb4b517769f7707514b0f7e3da5762ff0f1cc4 (patch)
tree36009d639a72d746c653b79d9562cd738cf3ac43 /ipalib/frontend.py
parent41d11f443bebc0a1303980363a4f751bfdbf2c12 (diff)
downloadfreeipa-77bb4b517769f7707514b0f7e3da5762ff0f1cc4.tar.gz
freeipa-77bb4b517769f7707514b0f7e3da5762ff0f1cc4.tar.xz
freeipa-77bb4b517769f7707514b0f7e3da5762ff0f1cc4.zip
Pylint cleanup.
Add more dynamic attribute info to IPATypeChecker in make-lint. Remove unnecessary pylint comments. Fix false positivies introduced by Pylint 0.26. https://fedorahosted.org/freeipa/ticket/3379
Diffstat (limited to 'ipalib/frontend.py')
-rw-r--r--ipalib/frontend.py20
1 files changed, 10 insertions, 10 deletions
diff --git a/ipalib/frontend.py b/ipalib/frontend.py
index fadcb8632..52ddf28c7 100644
--- a/ipalib/frontend.py
+++ b/ipalib/frontend.py
@@ -478,10 +478,10 @@ class Command(HasParam):
>>> list(c._repr_iter(login=u'Okay.', passwd=u'Private!'))
["u'Okay.'", "passwd=u'********'"]
"""
- for arg in self.args(): #pylint: disable=E1102
+ for arg in self.args():
value = params.get(arg.name, None)
yield repr(arg.safe_value(value))
- for option in self.options(): #pylint: disable=E1102
+ for option in self.options():
if option.name not in params:
continue
value = params[option.name]
@@ -506,7 +506,7 @@ class Command(HasParam):
def __args_2_params(self, values):
multivalue = False
- for (i, arg) in enumerate(self.args()): #pylint: disable=E1102
+ for (i, arg) in enumerate(self.args()):
assert not multivalue
if len(values) > i:
if arg.multivalue:
@@ -784,7 +784,7 @@ class Command(HasParam):
else:
self.max_args = None
self._create_param_namespace('options')
- params_nosort = tuple(self.args()) + tuple(self.options()) #pylint: disable=E1102
+ params_nosort = tuple(self.args()) + tuple(self.options())
def get_key(p):
if p.required:
if p.sortorder < 0:
@@ -963,7 +963,7 @@ class Command(HasParam):
rv = 0
- order = [p.name for p in self.output_params()] #pylint: disable=E1102
+ order = [p.name for p in self.output_params()]
if options.get('all', False):
order.insert(0, 'dn')
print_all = True
@@ -973,8 +973,8 @@ class Command(HasParam):
if options.get('raw', False):
labels = None
else:
- labels = dict((p.name, unicode(p.label)) for p in self.output_params()) #pylint: disable=E1102
- flags = dict((p.name, p.flags) for p in self.output_params()) #pylint: disable=E1102
+ labels = dict((p.name, unicode(p.label)) for p in self.output_params())
+ flags = dict((p.name, p.flags) for p in self.output_params())
for o in self.output:
outp = self.output[o]
@@ -1112,7 +1112,7 @@ class Object(HasParam):
self.__get_attrs('Property'), sort=False, name_attr='attr_name'
)
self._create_param_namespace('params')
- pkeys = filter(lambda p: p.primary_key, self.params()) #pylint: disable=E1102
+ pkeys = filter(lambda p: p.primary_key, self.params())
if len(pkeys) > 1:
raise ValueError(
'%s (Object) has multiple primary keys: %s' % (
@@ -1123,7 +1123,7 @@ class Object(HasParam):
if len(pkeys) == 1:
self.primary_key = pkeys[0]
self.params_minus_pk = NameSpace(
- filter(lambda p: not p.primary_key, self.params()), sort=False #pylint: disable=E1102
+ filter(lambda p: not p.primary_key, self.params()), sort=False
)
else:
self.primary_key = None
@@ -1141,7 +1141,7 @@ class Object(HasParam):
if len(names) == 1 and not isinstance(names[0], (Param, str)):
names = names[0]
minus = frozenset(names)
- for param in self.params(): #pylint: disable=E1102
+ for param in self.params():
if param.name in minus or param in minus:
continue
yield param