summaryrefslogtreecommitdiffstats
path: root/ipalib/aci.py
diff options
context:
space:
mode:
authorRob Crittenden <rcritten@redhat.com>2010-12-21 22:39:55 -0500
committerRob Crittenden <rcritten@redhat.com>2011-01-10 10:27:23 -0500
commit0a79836082b897ebf734d9073583769cb276937c (patch)
tree3269cf575f989df3ba9b88f13e0be70982018ebf /ipalib/aci.py
parentc69f4d0fed05a355ae5b9168066ad0ad01eb6487 (diff)
downloadfreeipa-0a79836082b897ebf734d9073583769cb276937c.zip
freeipa-0a79836082b897ebf734d9073583769cb276937c.tar.gz
freeipa-0a79836082b897ebf734d9073583769cb276937c.tar.xz
Setting an empty set of target attributes should raise an exception.
It is possible to create an ACI with attributes and then try to set that to None via a mod command later. We need to catch this and raise an exception. If all attributes are set to None in an aci then the attr target is removed from the ACI. This could result in an illegal ACI if there are no other targets. Having no targets is a legal state, just not a legal final state. ticket 647
Diffstat (limited to 'ipalib/aci.py')
-rwxr-xr-xipalib/aci.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/ipalib/aci.py b/ipalib/aci.py
index fc94126..abb2ebc 100755
--- a/ipalib/aci.py
+++ b/ipalib/aci.py
@@ -175,6 +175,10 @@ class ACI:
self.target['targetfilter']['operator'] = operator
def set_target_attr(self, attr, operator="="):
+ if not attr:
+ if 'targetattr' in self.target:
+ del self.target['targetattr']
+ return
if not type(attr) in (tuple, list):
attr = [attr]
self.target['targetattr'] = {}