diff options
author | Endi S. Dewata <edewata@redhat.com> | 2011-09-09 18:32:37 -0500 |
---|---|---|
committer | Endi S. Dewata <edewata@redhat.com> | 2011-09-13 05:52:44 +0000 |
commit | d4a28518733ec1c387469e05e4cda8a1ce8dd4d9 (patch) | |
tree | 9445df81a4d1fae7686f438f805c5c00611c2702 /install | |
parent | 452863dcbaf1a82b0a879e3a2f3e58ffa1803c2f (diff) | |
download | freeipa-d4a28518733ec1c387469e05e4cda8a1ce8dd4d9.tar.gz freeipa-d4a28518733ec1c387469e05e4cda8a1ce8dd4d9.tar.xz freeipa-d4a28518733ec1c387469e05e4cda8a1ce8dd4d9.zip |
Fixed missing optional field.
The optional uid field in user's adder dialog did not appear when
the link is clicked to show the field. This is a regression introduced
in the patch for ticket #1648.
The click handler for the link field has been moved into a new closure
so that the variables point to the correct elements.
Note: the duplicate code in IPA.details_table_section.create() and
IPA.dialog.create() will be addressed separately in ticket #1394.
Diffstat (limited to 'install')
-rw-r--r-- | install/ui/details.js | 14 | ||||
-rw-r--r-- | install/ui/dialog.js | 16 |
2 files changed, 19 insertions, 11 deletions
diff --git a/install/ui/details.js b/install/ui/details.js index 23f217afb..f7831114d 100644 --- a/install/ui/details.js +++ b/install/ui/details.js @@ -213,17 +213,21 @@ IPA.details_table_section = function(spec) { field.create(field_container); - if (field.optional){ + if (field.optional) { field_container.css('display', 'none'); + var link = $('<a/>', { text: IPA.messages.widget.optional, - href: '', - click: function() { + href: '' + }).appendTo(td); + + link.click(function(field_container, link) { + return function() { field_container.css('display', 'inline'); link.css('display', 'none'); return false; - } - }).appendTo(td); + }; + }(field_container, link)); } } }; diff --git a/install/ui/dialog.js b/install/ui/dialog.js index 2d6d941c6..86aefeffc 100644 --- a/install/ui/dialog.js +++ b/install/ui/dialog.js @@ -162,17 +162,21 @@ IPA.dialog = function(spec) { field.create(field_container); - if (field.optional){ - field_container.css('display','none'); + if (field.optional) { + field_container.css('display', 'none'); + var link = $('<a/>', { text: IPA.messages.widget.optional, - href: '', - click: function(){ + href: '' + }).appendTo(td); + + link.click(function(field_container, link) { + return function() { field_container.css('display', 'inline'); link.css('display', 'none'); return false; - } - }).appendTo(td); + }; + }(field_container, link)); } } |