webui: better error reporting

- ActionDropdownWidget - report error if required action is missing
- report build errors to console

Reviewed-By: Martin Basti <mbasti@redhat.com>

4 files changed, 11 insertions, 1 deletions

diff --git a/install/ui/src/freeipa/Application_controller.js b/install/ui/src/freeipa/Application_controller.js
index dc76fea59..ca08770fe 100644
--- a/install/ui/src/freeipa/Application_controller.js
+++ b/install/ui/src/freeipa/Application_controller.js
@@ -262,7 +262,6 @@ define([
             if (error.results) {
                 var msg = error.results.message;
                 var stack = error.results.stack.toString();
-                window.console.error(msg);
                 window.console.error(stack);
                 details.append('<h3>Technical details:</h3>');
                 details.append($('<div/>', { text: error.results.message }));
diff --git a/install/ui/src/freeipa/_base/Builder.js b/install/ui/src/freeipa/_base/Builder.js
index 029f8947f..05ff2dd6e 100644
--- a/install/ui/src/freeipa/_base/Builder.js
+++ b/install/ui/src/freeipa/_base/Builder.js
@@ -356,6 +356,7 @@ define(['dojo/_base/declare',
                     // object is not to be built
                     obj = null;
                 } else {
+                    window.console.error(e.stack);
                     throw e;
                 }
             }
diff --git a/install/ui/src/freeipa/_base/Singleton_registry.js b/install/ui/src/freeipa/_base/Singleton_registry.js
index 0c89e65bf..18b0c420a 100644
--- a/install/ui/src/freeipa/_base/Singleton_registry.js
+++ b/install/ui/src/freeipa/_base/Singleton_registry.js
@@ -69,6 +69,10 @@ define(['dojo/_base/declare',
                     obj = this._map[type] = this.builder.build(type);
                 } catch (e) {
                     if (e.code === 'no-ctor-fac') obj = null;
+                    else {
+                        window.console.error('Error while building: ' + type);
+                        throw e;
+                    }
                 }
             }
 
diff --git a/install/ui/src/freeipa/widgets/ActionDropdownWidget.js b/install/ui/src/freeipa/widgets/ActionDropdownWidget.js
index c43c79b54..2ddcff64b 100644
--- a/install/ui/src/freeipa/widgets/ActionDropdownWidget.js
+++ b/install/ui/src/freeipa/widgets/ActionDropdownWidget.js
@@ -74,6 +74,12 @@ define(['dojo/_base/declare',
             for (i=0; i<this.action_names.length; i++) {
                 name = this.action_names[i];
                 action = this.facet.actions.get(name);
+                if (!action) {
+                    window.console.error(
+                        "ActionDropDown: cannot find action: " + name +
+                        "\nFacet: "+facet.name);
+                    continue;
+                }
                 this.add_action(action, true);
             }
             this.recreate_options();