diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2012-03-09 15:52:05 +0100 |
|---|---|---|
| committer | Petr Vobornik <pvoborni@redhat.com> | 2012-03-15 16:08:02 +0100 |
| commit | 3ca0f6aee5b04758f8473359cc14979d27d31530 (patch) | |
| tree | 3d7b2ef8a65219e66e3f7155b1a06da5608c3f8b /install/ui/test/widget_tests.js | |
| parent | 51601ac794ce589981c0cc3501d91518cea27f15 (diff) | |
| download | freeipa-3ca0f6aee5b04758f8473359cc14979d27d31530.tar.gz freeipa-3ca0f6aee5b04758f8473359cc14979d27d31530.tar.xz freeipa-3ca0f6aee5b04758f8473359cc14979d27d31530.zip | |
Fixed evaluating checkbox dirty status
Problem:
When value in checkbox is modified twice in a row (so it is at its original value) an 'undo' button is still visible even when it shouldn't be.
Cause:
IPA server sends boolean values as 'TRUE' or 'FALSE' (strings). Checkbox_widget converts them to JavaScript? boolean (true, false). Save method in checkbox_widget is returning array with a boolean. So test_dirty method always evaluates to dirty because 'FALSE' != false.
This patch is fixing the problem.
https://fedorahosted.org/freeipa/ticket/2494
Diffstat (limited to 'install/ui/test/widget_tests.js')
| -rw-r--r-- | install/ui/test/widget_tests.js | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/install/ui/test/widget_tests.js b/install/ui/test/widget_tests.js index 951f943a1..489572c2c 100644 --- a/install/ui/test/widget_tests.js +++ b/install/ui/test/widget_tests.js @@ -223,7 +223,9 @@ test("Testing checkbox widget.", function() { spec = {name:'title'}; base_widget_test('test_value'); - var mock_record = { 'title': 'TRUE' }; + //Changing mock record from 'TRUE' to true. Value normalization is field's + //job. Checkbox should work with booleans values. + var mock_record = { 'title': [true] }; widget.update(mock_record.title); same(widget.save(),[true], "Checkbox is set"); |