Modify serial associator to use batch

https://fedorahosted.org/freeipa/ticket/1688

The serial associator is used to execute a command multiple times with different parameters. This is used for adding/removing a user into/from multiple groups. It has some issues:

Each command is executed one-by-one, so it could be slow.
  * If there's a failure the rest of the commands will not be executed.
  * This can be fixed by putting the commands into a batch and execute them at once.

1 files changed, 19 insertions, 17 deletions

diff --git a/install/ui/association.js b/install/ui/association.js
index b79a18f06..1c9776b0e 100644
--- a/install/ui/association.js
+++ b/install/ui/association.js
@@ -64,28 +64,30 @@ IPA.serial_associator = function(spec) {
             return;
         }
 
-        var value = that.values.shift();
-        if (!value) {
-            that.on_success();
-            return;
-        }
-
-        var args = [value];
-        var options = {};
-        options[that.entity.name] = that.pkey;
-
-        var command = IPA.command({
-            entity: that.other_entity,
-            method: that.method,
-            args: args,
-            options: options,
-            on_success: that.execute,
+        var batch = IPA.batch_command({
+            on_success: that.on_success,
             on_error: that.on_error
         });
 
+        var args, options, command;
+
+        for(var i=0; i < that.values.length; i++) {
+            args = [that.values[i]];
+            options = {};
+            options[that.entity.name] = that.pkey;
+
+            command = IPA.command({
+                entity: that.other_entity,
+                method: that.method,
+                args: args,
+                options: options
+            });
+
+            batch.add_command(command);
+        }
         //alert(JSON.stringify(command.to_json()));
 
-        command.execute();
+        batch.execute();
     };
 
     return that;