diff options
author | Petr Vobornik <pvoborni@redhat.com> | 2012-02-29 18:53:11 +0100 |
---|---|---|
committer | Endi S. Dewata <edewata@redhat.com> | 2012-03-02 11:45:21 -0600 |
commit | 31eebda584d556454104a8fbf26974b6b49d9589 (patch) | |
tree | 5a883895aed910941817a7cd750e5dbbae23e679 /install/ui/add.js | |
parent | afad0775e16e52aa2d6637e809ad748ace838bea (diff) | |
download | freeipa-31eebda584d556454104a8fbf26974b6b49d9589.tar.gz freeipa-31eebda584d556454104a8fbf26974b6b49d9589.tar.xz freeipa-31eebda584d556454104a8fbf26974b6b49d9589.zip |
Removed CSV creation from UI
Creating CSV values in UI is unnecessary and error-prone because server converts them back to list. Possible problems with values containing commas may occur. All occurrences of CSV joining were therefore removed.
https://fedorahosted.org/freeipa/ticket/2227
Diffstat (limited to 'install/ui/add.js')
-rw-r--r-- | install/ui/add.js | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/install/ui/add.js b/install/ui/add.js index 9b473ccc2..671d3f1fc 100644 --- a/install/ui/add.js +++ b/install/ui/add.js @@ -123,16 +123,14 @@ IPA.entity_adder_dialog = function(spec) { var field = fields[j]; var values = record[field.param]; - if (!values) continue; - - // TODO: Handle multi-valued attributes like in detail facet's update() - var value = values.join(','); - if (!value) continue; + if (!values || values.length === 0) continue; if (field.param === pkey_name) { - command.add_arg(value); + command.add_arg(values[0]); + } else if (values.length === 1) { + command.set_option(field.param, values[0]); } else { - command.set_option(field.param, value); + command.set_option(field.param, values); } } |