summaryrefslogtreecommitdiffstats
path: root/daemons
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-02-22 13:56:06 +0100
committerMartin Kosek <mkosek@redhat.com>2013-02-28 12:33:28 +0100
commitd10c043e92b86e50ece5f80e6a987013d5de6fb1 (patch)
tree10732222a8f3e266b025218f1af1264f19f76bb6 /daemons
parent99ff913b89f975295839db380512d80c07031c9a (diff)
downloadfreeipa-d10c043e92b86e50ece5f80e6a987013d5de6fb1.tar.gz
freeipa-d10c043e92b86e50ece5f80e6a987013d5de6fb1.tar.xz
freeipa-d10c043e92b86e50ece5f80e6a987013d5de6fb1.zip
ipa-pwd: Unchecked return value ipapwd_chpwop()
Fixes https://fedorahosted.org/freeipa/ticket/3427
Diffstat (limited to 'daemons')
-rw-r--r--daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
index 7fcf647f7..974eda318 100644
--- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
+++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
@@ -247,7 +247,11 @@ parse_req_done:
slapi_sdn_free(&sdn);
if (be) {
chpwop_pb = slapi_pblock_new();
- slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be);
+ if (slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be)) {
+ LOG_FATAL("slapi_pblock_set failed!\n");
+ rc = LDAP_OPERATIONS_ERROR;
+ goto free_and_return;
+ }
rc = slapi_back_transaction_begin(chpwop_pb);
if (rc) {
LOG_FATAL("failed to start transaction\n");