diff options
| author | Martin Babinsky <mbabinsk@redhat.com> | 2015-01-28 16:27:19 +0100 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2015-01-30 11:02:16 +0100 |
| commit | b0611bc6c36ea258addb6a07a464f5867bc489a7 (patch) | |
| tree | d8cac1aa67f8bdad5d34df7edfa0c97399c9a46d /daemons/ipa-slapi-plugins | |
| parent | d800ac867baf7335e0c4b55b945b4c06d4c0567e (diff) | |
| download | freeipa-b0611bc6c36ea258addb6a07a464f5867bc489a7.tar.gz freeipa-b0611bc6c36ea258addb6a07a464f5867bc489a7.tar.xz freeipa-b0611bc6c36ea258addb6a07a464f5867bc489a7.zip | |
ipa-pwd-extop: added an informational comment about intentional fallthrough
This patch is related to this defect reported by covscan in FreeIPA code:
"""
Error: MISSING_BREAK (CWE-484):
/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c:631: unterminated_case: The
case for value "2" is not terminated by a 'break' statement.
/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c:638: fallthrough: The above
case falls through to this one.
"""
Added a comment informing about intentional falltrough in this place, so that
future generations reading the code don't get confused.
The patch is the part of a series related to
https://fedorahosted.org/freeipa/ticket/4795
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
Diffstat (limited to 'daemons/ipa-slapi-plugins')
| -rw-r--r-- | daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c index 84eff1701..1c6838052 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c @@ -635,6 +635,8 @@ static int ipapwd_pre_mod(Slapi_PBlock *pb) is_smb = 0; is_ipant = 0; + /* After examining the output of covscan, we think that this + * fallthrough is intentional.*/ case LDAP_MOD_ADD: if (!lmod->mod_bvalues || !lmod->mod_bvalues[0]) { |