Fix various issues found by Coverity

2 files changed, 11 insertions, 7 deletions

diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
index f48bead04..47d4d68d1 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
@@ -137,10 +137,12 @@ int parse_request_data(struct berval *req_val, struct extdom_req **_req)
             break;
         default:
             ber_free(ber, 1);
+            free(req);
             return LDAP_PROTOCOL_ERROR;
     }
     ber_free(ber, 1);
     if (tag == LBER_ERROR) {
+        free(req);
         return LDAP_PROTOCOL_ERROR;
     }
 
@@ -284,11 +286,6 @@ static int get_domain_info(struct ipa_extdom_ctx *ctx, const char *domain_name,
     domain_info->flat_name = slapi_entry_attr_get_charptr(e[0],
                                                           "ipaNTFlatName");
 
-    /* TODO: read range from LDAP server */
-/*
-    range.min = 200000;
-    range.max = 400000;
-*/
     ret = set_domain_range(ctx, domain_info->sid, &range);
     if (ret != 0) {
         goto done;
@@ -313,6 +310,11 @@ done:
     slapi_free_search_results_internal(pb);
     slapi_pblock_destroy(pb);
     free(filter);
+
+    if (ret != 0) {
+        free_domain_info(domain_info);
+    }
+
     return ret;
 
 }
diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
index d5a2f604c..f36878c37 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
@@ -170,13 +170,15 @@ static int ipa_extdom_init_ctx(Slapi_PBlock *pb, struct ipa_extdom_ctx **_ctx)
     slapi_pblock_get(pb, SLAPI_PLUGIN_CONFIG_ENTRY, &e);
     if (!e) {
         LOG_FATAL("Plugin configuration not found!\n");
-        return -1;
+        ret = -1;
+        goto done;
     }
 
     ctx->base_dn = slapi_entry_attr_get_charptr(e, "nsslapd-basedn");
     if (!ctx->base_dn) {
         LOG_FATAL("Base DN not found in plugin configuration not found!\n");
-        return -1;
+        ret = -1;
+        goto done;
     }