summaryrefslogtreecommitdiffstats
path: root/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2012-10-02 11:25:04 +0200
committerMartin Kosek <mkosek@redhat.com>2012-10-17 14:32:37 +0200
commitc1b922352fd88909401bad914cf660f29d5b063c (patch)
tree76c8095e74ef5deaa8715938801ae85ee15324eb /daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
parent2d42737d018ac09253f73c89a90f21dddce4fc6c (diff)
downloadfreeipa-c1b922352fd88909401bad914cf660f29d5b063c.tar.gz
freeipa-c1b922352fd88909401bad914cf660f29d5b063c.tar.xz
freeipa-c1b922352fd88909401bad914cf660f29d5b063c.zip
Fix various issues found by Coverity
Diffstat (limited to 'daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c')
-rw-r--r--daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
index f48bead04..47d4d68d1 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
@@ -137,10 +137,12 @@ int parse_request_data(struct berval *req_val, struct extdom_req **_req)
break;
default:
ber_free(ber, 1);
+ free(req);
return LDAP_PROTOCOL_ERROR;
}
ber_free(ber, 1);
if (tag == LBER_ERROR) {
+ free(req);
return LDAP_PROTOCOL_ERROR;
}
@@ -284,11 +286,6 @@ static int get_domain_info(struct ipa_extdom_ctx *ctx, const char *domain_name,
domain_info->flat_name = slapi_entry_attr_get_charptr(e[0],
"ipaNTFlatName");
- /* TODO: read range from LDAP server */
-/*
- range.min = 200000;
- range.max = 400000;
-*/
ret = set_domain_range(ctx, domain_info->sid, &range);
if (ret != 0) {
goto done;
@@ -313,6 +310,11 @@ done:
slapi_free_search_results_internal(pb);
slapi_pblock_destroy(pb);
free(filter);
+
+ if (ret != 0) {
+ free_domain_info(domain_info);
+ }
+
return ret;
}