diff options
author | Jan Cholasta <jcholast@redhat.com> | 2011-04-29 13:15:39 +0200 |
---|---|---|
committer | Rob Crittenden <rcritten@redhat.com> | 2011-05-09 16:23:40 -0400 |
commit | 16d1db499676ec7070becbb73fdf73d1af5645b3 (patch) | |
tree | d245a2a26d393cdc6e9087e6134d070b46539f94 /daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c | |
parent | d3f74d2b7cee01001e6ede2ba59dcb34522b59cf (diff) | |
download | freeipa-16d1db499676ec7070becbb73fdf73d1af5645b3.tar.gz freeipa-16d1db499676ec7070becbb73fdf73d1af5645b3.tar.xz freeipa-16d1db499676ec7070becbb73fdf73d1af5645b3.zip |
Fix issues found by Coverity.
tickets 1166, 1167, 1168, 1169
Diffstat (limited to 'daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c')
-rw-r--r-- | daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c b/daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c index 161a73177..5d276de53 100644 --- a/daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c +++ b/daemons/ipa-slapi-plugins/ipa-enrollment/ipa_enrollment.c @@ -155,7 +155,7 @@ ipa_join(Slapi_PBlock *pb) errMesg = "Kerberos realm is not set.\n"; LOG_FATAL("%s", errMesg); rc = LDAP_OPERATIONS_ERROR; - goto done; + goto free_and_return; } /* Get Bind DN */ @@ -234,7 +234,11 @@ ipa_join(Slapi_PBlock *pb) */ is_root = slapi_dn_isroot(bindDN); - slapi_pblock_set(pb, SLAPI_REQUESTOR_ISROOT, &is_root); + if (slapi_pblock_set(pb, SLAPI_REQUESTOR_ISROOT, &is_root)) { + LOG_FATAL("slapi_pblock_set failed!\n"); + rc = LDAP_OPERATIONS_ERROR; + goto free_and_return; + } /* In order to perform the access control check, * we need to select a backend (even though @@ -242,7 +246,11 @@ ipa_join(Slapi_PBlock *pb) */ sdn = slapi_sdn_new_dn_byval(bindDN); be = slapi_be_select(sdn); - slapi_pblock_set(pb, SLAPI_BACKEND, be); + if (slapi_pblock_set(pb, SLAPI_BACKEND, be)) { + LOG_FATAL("slapi_pblock_set failed!\n"); + rc = LDAP_OPERATIONS_ERROR; + goto free_and_return; + } /* Access Strategy: * If the user has WRITE-ONLY access, a new keytab is set on the entry. |