diff options
| author | Martin Babinsky <mbabinsk@redhat.com> | 2015-01-28 16:24:01 +0100 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2015-01-30 11:02:16 +0100 |
| commit | eb09e77f16f06c2f488c495785c42bda0bb257b4 (patch) | |
| tree | 5a5fb45a9119bbd67d909ac104df79d593e09153 /daemons/ipa-kdb/ipa_kdb_mspac.c | |
| parent | 98b1690a0e18f85560c092f8abac5f451bddf2e7 (diff) | |
| download | freeipa-eb09e77f16f06c2f488c495785c42bda0bb257b4.tar.gz freeipa-eb09e77f16f06c2f488c495785c42bda0bb257b4.tar.xz freeipa-eb09e77f16f06c2f488c495785c42bda0bb257b4.zip | |
always get PAC for client principal if AS_REQ is true
This patch proposes a fix for the following defect reported by covscan in
FreeIPA master code:
"""
Error: DEADCODE (CWE-561):
/daemons/ipa-kdb/ipa_kdb_mspac.c:2013: assignment: Assigning: "client_entry" =
"NULL".
/daemons/ipa-kdb/ipa_kdb_mspac.c:2077: null: At condition
"client_entry", the value of "client_entry" must be "NULL".
/daemons/ipa-kdb/ipa_kdb_mspac.c:2077: dead_error_condition: The condition
"client_entry" cannot be true.
/daemons/ipa-kdb/ipa_kdb_mspac.c:2077:
dead_error_line: Execution cannot reach the expression "client_entry" inside
this statement: "kerr = ipadb_get_pac(contex...".
"""
This is a part of a series of patches related to
https://fedorahosted.org/freeipa/ticket/4795
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
Diffstat (limited to 'daemons/ipa-kdb/ipa_kdb_mspac.c')
| -rw-r--r-- | daemons/ipa-kdb/ipa_kdb_mspac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c index 22774e023..0f47d1f4b 100644 --- a/daemons/ipa-kdb/ipa_kdb_mspac.c +++ b/daemons/ipa-kdb/ipa_kdb_mspac.c @@ -2071,7 +2071,7 @@ krb5_error_code ipadb_sign_authdata(krb5_context context, } } - kerr = ipadb_get_pac(context, client_entry ? client_entry : client, &pac); + kerr = ipadb_get_pac(context, client, &pac); if (kerr != 0 && kerr != ENOENT) { goto done; } |