Do not open dialog in a container

https://fedorahosted.org/freeipa/ticket/3904

8 files changed, 27 insertions, 28 deletions

diff --git a/install/ui/src/freeipa/association.js b/install/ui/src/freeipa/association.js
index 7b4a78d5a..f976d58e4 100644
--- a/install/ui/src/freeipa/association.js
+++ b/install/ui/src/freeipa/association.js
@@ -520,7 +520,7 @@ IPA.association_table_widget = function (spec) {
                 that.show_add_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_add_dialog();
@@ -540,7 +540,7 @@ IPA.association_table_widget = function (spec) {
                 that.show_remove_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_remove_dialog();
@@ -650,7 +650,7 @@ IPA.association_table_widget = function (spec) {
             );
         };
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.add = function(values, on_success, on_error) {
@@ -714,7 +714,7 @@ IPA.association_table_widget = function (spec) {
         };
 
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.remove = function(values, on_success, on_error) {
@@ -1145,7 +1145,7 @@ exp.association_facet = IPA.association_facet = function (spec, no_init) {
             associator.execute();
         };
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.show_remove_dialog = function() {
@@ -1198,7 +1198,7 @@ exp.association_facet = IPA.association_facet = function (spec, no_init) {
             associator.execute();
         };
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.get_records_map = function(data) {
@@ -1431,7 +1431,7 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) {
         dialog.added.attach(function() {
             that.refresh();
         });
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.show_remove_dialog = function() {
@@ -1467,7 +1467,7 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) {
         };
 
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.remove = function(values, on_success, on_error) {
diff --git a/install/ui/src/freeipa/automember.js b/install/ui/src/freeipa/automember.js
index 703b4a173..50fc69741 100644
--- a/install/ui/src/freeipa/automember.js
+++ b/install/ui/src/freeipa/automember.js
@@ -208,7 +208,7 @@ IPA.automember.rule_search_facet = function(spec) {
         }
         dialog.pkey_prefix = that.managed_entity_pkey_prefix();
         dialog.group_type = that.group_type;
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.create_remove_dialog = function() {
diff --git a/install/ui/src/freeipa/dialog.js b/install/ui/src/freeipa/dialog.js
index 337d2e610..668984c2b 100644
--- a/install/ui/src/freeipa/dialog.js
+++ b/install/ui/src/freeipa/dialog.js
@@ -413,13 +413,12 @@ IPA.dialog = function(spec) {
      * Open dialog
      * @param {jQuery} container
      */
-    that.open = function(container) {
+    that.open = function() {
 
         that.create_dialog();
         that.reset();
 
-        container = container || document.body;
-        that.dom_node.appendTo(container);
+        that.dom_node.appendTo(document.body);
 
         that.register_listeners();
         IPA.opened_dialogs.add_dialog(that);
diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index b2eeb7896..8876eab1f 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -1220,7 +1220,7 @@ IPA.dns.record_details_facet = function(spec) {
         if (!data.result.result.idnsname) {
             that.reset();
             var dialog = IPA.dnsrecord_redirection_dialog();
-            dialog.open(that.container);
+            dialog.open();
             return;
         }
 
@@ -1734,7 +1734,7 @@ IPA.dns.record_type_table_widget = function(spec) {
                 that.show_add_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_add_dialog();
@@ -1754,7 +1754,7 @@ IPA.dns.record_type_table_widget = function(spec) {
                 that.show_remove_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_remove_dialog();
@@ -1792,7 +1792,7 @@ IPA.dns.record_type_table_widget = function(spec) {
         };
 
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.remove = function(values, pkey, on_success, on_error) {
@@ -1907,7 +1907,7 @@ IPA.dns.record_type_table_widget = function(spec) {
     that.show_add_dialog = function() {
 
         var dialog = that.create_add_dialog();
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.create_mod_dialog = function() {
diff --git a/install/ui/src/freeipa/ipa.js b/install/ui/src/freeipa/ipa.js
index b708ed004..df31bfbba 100644
--- a/install/ui/src/freeipa/ipa.js
+++ b/install/ui/src/freeipa/ipa.js
@@ -1911,7 +1911,7 @@ IPA.create_4304_error_handler = function(adder_dialog) {
             });
         }
 
-        dialog.open(adder_dialog.container);
+        dialog.open();
     };
 };
 
diff --git a/install/ui/src/freeipa/search.js b/install/ui/src/freeipa/search.js
index c2e678a35..10ed0cb9f 100644
--- a/install/ui/src/freeipa/search.js
+++ b/install/ui/src/freeipa/search.js
@@ -165,7 +165,7 @@ IPA.search_facet = function(spec, no_init) {
             });
         }
         dialog.pkey_prefix = that.managed_entity_pkey_prefix();
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.create_remove_dialog = function() {
@@ -201,7 +201,7 @@ IPA.search_facet = function(spec, no_init) {
     that.show_remove_dialog = function() {
 
         var dialog = that.create_remove_dialog();
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.find = function() {
diff --git a/install/ui/src/freeipa/sudo.js b/install/ui/src/freeipa/sudo.js
index aa2597be1..e50615bd7 100644
--- a/install/ui/src/freeipa/sudo.js
+++ b/install/ui/src/freeipa/sudo.js
@@ -768,7 +768,7 @@ IPA.sudo.options_section = function(spec) {
             dialog.callback = function() {
                 that.show_add_dialog();
             };
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_add_dialog();
@@ -784,7 +784,7 @@ IPA.sudo.options_section = function(spec) {
             dialog.callback = function() {
                 that.show_remove_dialog();
             };
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_remove_dialog();
@@ -852,7 +852,7 @@ IPA.sudo.options_section = function(spec) {
             }
         });
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.show_remove_dialog = function() {
@@ -919,7 +919,7 @@ IPA.sudo.options_section = function(spec) {
             batch.execute();
         };
 
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.reload = function() {
diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js
index dc1d0f27b..3bd067957 100644
--- a/install/ui/src/freeipa/widget.js
+++ b/install/ui/src/freeipa/widget.js
@@ -2692,7 +2692,7 @@ IPA.attribute_table_widget = function(spec) {
                 that.show_add_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_add_dialog();
@@ -2712,7 +2712,7 @@ IPA.attribute_table_widget = function(spec) {
                 that.show_remove_dialog();
             };
 
-            dialog.open(that.container);
+            dialog.open();
 
         } else {
             that.show_remove_dialog();
@@ -2722,7 +2722,7 @@ IPA.attribute_table_widget = function(spec) {
     that.show_remove_dialog = function() {
 
         var dialog = that.create_remove_dialog();
-        if (dialog) dialog.open(that.container);
+        if (dialog) dialog.open();
     };
 
     that.create_remove_dialog = function() {
@@ -2882,7 +2882,7 @@ IPA.attribute_table_widget = function(spec) {
     that.show_add_dialog = function() {
 
         var dialog = that.create_add_dialog();
-        dialog.open(that.container);
+        dialog.open();
     };
 
     that.update = function(values) {