diff options
| author | Simo Sorce <ssorce@redhat.com> | 2008-05-28 16:24:03 -0400 |
|---|---|---|
| committer | Simo Sorce <ssorce@redhat.com> | 2008-05-29 09:43:20 -0400 |
| commit | dc7d62d543575ad1dc02869b820cdce996b45eff (patch) | |
| tree | 48f989775ff854a9b735034f175348a9f7be6602 | |
| parent | 8f082f2d4f03b66cbd8548c0900111f8d2df799b (diff) | |
| download | freeipa-dc7d62d543575ad1dc02869b820cdce996b45eff.tar.gz freeipa-dc7d62d543575ad1dc02869b820cdce996b45eff.tar.xz freeipa-dc7d62d543575ad1dc02869b820cdce996b45eff.zip | |
Fix crash bug in ipa_kpasswd
| -rw-r--r-- | ipa-server/ipa-kpasswd/ipa_kpasswd.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ipa-server/ipa-kpasswd/ipa_kpasswd.c b/ipa-server/ipa-kpasswd/ipa_kpasswd.c index 944ac6af3..1e5ca1f11 100644 --- a/ipa-server/ipa-kpasswd/ipa_kpasswd.c +++ b/ipa-server/ipa-kpasswd/ipa_kpasswd.c @@ -317,7 +317,7 @@ int ldap_pwd_change(char *client_name, char *realm_name, krb5_data pwd, char **e LDAP *ld = NULL; BerElement *ctrl = NULL; BerElement *sctrl = NULL; - struct berval control; + struct berval *control = NULL; struct berval newpw; char hostname[1024]; struct berval **ncvals; @@ -485,7 +485,7 @@ int ldap_pwd_change(char *client_name, char *realm_name, krb5_data pwd, char **e /* perform password change */ ret = ldap_extended_operation(ld, LDAP_EXOP_MODIFY_PASSWD, - &control, NULL, NULL, + control, NULL, NULL, &msgid); if (ret != LDAP_SUCCESS) { syslog(LOG_ERR, "ldap_extended_operation() failed. (%d)", ret); @@ -635,6 +635,7 @@ done: if (sctrl) ber_free(sctrl, 1); if (srvctrl) ldap_controls_free(srvctrl); if (res) ldap_msgfree(res); + if (control) ber_bvfree(control); free(exterr1); free(exterr2); free(userdn); |