summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRob Crittenden <rcritten@redhat.com>2011-10-14 09:36:26 -0400
committerRob Crittenden <rcritten@redhat.com>2011-10-13 16:37:23 -0400
commitc75b177dc6de395a377e56d772fc0b0762ec4814 (patch)
treea8121a5d7791d9276a4d2debb3a24f21a65c8b60
parent0ead8b4194fe6c9403e4ed3ef595494fd0a912e8 (diff)
downloadfreeipa-c75b177dc6de395a377e56d772fc0b0762ec4814.tar.gz
freeipa-c75b177dc6de395a377e56d772fc0b0762ec4814.tar.xz
freeipa-c75b177dc6de395a377e56d772fc0b0762ec4814.zip
Handle an empty value in a name/value pair in config_replace_variables()
This would blow up if you tried to append a value to an entry that looked like: NAME= https://fedorahosted.org/freeipa/ticket/1983
-rw-r--r--ipapython/ipautil.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py
index b00259494..75e8e6fdf 100644
--- a/ipapython/ipautil.py
+++ b/ipapython/ipautil.py
@@ -1235,7 +1235,9 @@ $)''', re.VERBOSE)
old_values[option] = value
if appendvars and option in appendvars:
# append new value unless it is already existing in the original one
- if value.find(appendvars[option]) == -1:
+ if not value:
+ new_line = u"%s=%s\n" % (option, appendvars[option])
+ elif value.find(appendvars[option]) == -1:
new_line = u"%s=%s %s\n" % (option, value, appendvars[option])
old_values[option] = value
new_config.write(new_line)