diff options
author | Oleg Nesterov <oleg@redhat.com> | 2012-09-23 21:30:44 +0200 |
---|---|---|
committer | Anton Arapov <anton@redhat.com> | 2012-10-29 11:50:16 +0100 |
commit | 2943fbbe0cfe8e37290179c064c7685cc1248f28 (patch) | |
tree | a65245e7ce09e6e60cda1c892bdb7e7f7b050bfa /arch/x86/kernel/uprobes.c | |
parent | 47ebdea1c032389b070c716b36d1a7a011706134 (diff) | |
download | kernel-uprobes-2943fbbe0cfe8e37290179c064c7685cc1248f28.tar.gz kernel-uprobes-2943fbbe0cfe8e37290179c064c7685cc1248f28.tar.xz kernel-uprobes-2943fbbe0cfe8e37290179c064c7685cc1248f28.zip |
uprobes: Kill set_orig_insn()->is_swbp_at_addr()
Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense,
although it can't prevent all confusions.
But the usage of is_swbp_at_addr() is equally confusing, and it adds
the extra get_user_pages() we can avoid.
This patch removes set_orig_insn()->is_swbp_at_addr() but changes
write_opcode() to do the necessary checks before replace_page().
Perhaps it also makes sense to ensure PAGE_MAPPING_ANON in unregister
case.
find_active_uprobe() becomes the only user of is_swbp_at_addr(),
we can change its semantics.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'arch/x86/kernel/uprobes.c')
0 files changed, 0 insertions, 0 deletions