summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2011-06-19 12:43:33 +0000
committerDavid S. Miller <davem@davemloft.net>2011-06-19 16:28:02 -0700
commit658924dc9ae2ca8e3c46f36306f5dbd501cf4688 (patch)
treea10de7dfe5bd02f963455559868d4574cb08724c
parent00ce2d5614a67521241d024c6e50afe3bd3df049 (diff)
downloadkernel-uprobes-658924dc9ae2ca8e3c46f36306f5dbd501cf4688.tar.gz
kernel-uprobes-658924dc9ae2ca8e3c46f36306f5dbd501cf4688.tar.xz
kernel-uprobes-658924dc9ae2ca8e3c46f36306f5dbd501cf4688.zip
hp100: fix an skb->len race
As soon as skb is given to hardware and spinlock released, TX completion can free skb under us. Therefore, we should update netdev stats before spinlock release. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/hp100.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/hp100.c b/drivers/net/hp100.c
index 8e10d2f6a5a..c3ecb118c1d 100644
--- a/drivers/net/hp100.c
+++ b/drivers/net/hp100.c
@@ -1580,12 +1580,12 @@ static netdev_tx_t hp100_start_xmit_bm(struct sk_buff *skb,
hp100_outl(ringptr->pdl_paddr, TX_PDA_L); /* Low Prio. Queue */
lp->txrcommit++;
- spin_unlock_irqrestore(&lp->lock, flags);
- /* Update statistics */
dev->stats.tx_packets++;
dev->stats.tx_bytes += skb->len;
+ spin_unlock_irqrestore(&lp->lock, flags);
+
return NETDEV_TX_OK;
drop: