diff options
| author | Greg Hudson <ghudson@mit.edu> | 2013-03-28 15:59:07 -0400 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2013-03-28 15:59:07 -0400 |
| commit | 49f908733b5ddf491e53c7c84d0cbae263e31eae (patch) | |
| tree | d13d01f8ed933b0334a05cbf79af971984089cea | |
| parent | 43bfc7043301f4d0a9b7ab72f53899685704305d (diff) | |
| download | krb5-49f908733b5ddf491e53c7c84d0cbae263e31eae.tar.gz krb5-49f908733b5ddf491e53c7c84d0cbae263e31eae.tar.xz krb5-49f908733b5ddf491e53c7c84d0cbae263e31eae.zip | |
Fix kdb_ldap_create_principal cleanup
entry must be initialized before all code which can jump to cleanup.
| -rw-r--r-- | src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c b/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c index 1050fcd73e..7494928647 100644 --- a/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c +++ b/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c @@ -1344,6 +1344,8 @@ kdb_ldap_create_principal(krb5_context context, krb5_principal princ, krb5_timestamp now; krb5_actkvno_node actkvno; + memset(&entry, 0, sizeof(entry)); + if ((pblock == NULL) || (context == NULL)) { retval = EINVAL; goto cleanup; @@ -1355,8 +1357,6 @@ kdb_ldap_create_principal(krb5_context context, krb5_principal princ, goto cleanup; } - memset(&entry, 0, sizeof(entry)); - tl_data = malloc(sizeof(*tl_data)); if (tl_data == NULL) { retval = ENOMEM; |